Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: intro MF v2 #12407

Closed
wants to merge 9 commits into from
Closed

feat: intro MF v2 #12407

wants to merge 9 commits into from

Conversation

fz6m
Copy link
Member

@fz6m fz6m commented May 19, 2024

close #12365

支持 mf v2 。

  1. 虽然 mf 没有公开放出来,但还是有少数 umi 的社区忠实用户在使用 mf 功能,到了 mf v2 也有一定的诉求,故做了这个功能。

  2. mf v2 的功能选项上相比 v1 之前的,砍掉了一些选项,并且还不支持 mfsu (后续有需求可以继续追加)。

  3. 由于 mf v2 的插件内大量的使用了 webpack deep import ,为此我们要添加所有的深层导入路径。

mf v2 目前有一些优点:

1、支持同步 type (会自动打包、下载远程组件对应的 type)。

2、可以运行时加载,意味着使用者可以不用 MF 插件来加载远程组件(此功能还没有在 demo 中尝试)。

3、产物 manifest 化,只需要从清单 json 加载,不需要从 js 加载,清单内记载了所有相关的信息和资源路径。

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview May 19, 2024 3:41am

Copy link

coderabbitai bot commented May 19, 2024

Important

Auto Review Skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

31 files out of 87 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc
Copy link
Member

sorrycc commented May 30, 2024

1、mf v2 哪里有介绍吗?
2、webpack 有升级吗?还是就做了重新打包?

@fz6m
Copy link
Member Author

fz6m commented May 30, 2024

  1. MF v2 在 module-federation/core ,目测是原 MF 作者进入字节后结合字节内部对 MF v1 的改造后,整合出来的面向公司需求的产品。

  2. 没对 webpack 升级,只重新打包了,因为新增了一些导出给 MF 插件使用。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] umi 4 使用 MF v2 插件问题
2 participants