Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing node:process named exports #268

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Jun 18, 2024

Add missing named exports of node:process

@pi0 pi0 self-assigned this Jun 18, 2024
@pi0
Copy link
Member Author

pi0 commented Jun 18, 2024

Merging to iterate faster. @IgorMinar @jculvey please comment if have any feedbacks.

@pi0 pi0 merged commit 5ca3ed3 into main Jun 18, 2024
2 checks passed
@pi0 pi0 deleted the chore/missing_process branch June 18, 2024 14:08
@IgorMinar
Copy link
Collaborator

@pi0 I'm not too keen on this change. I was hoping that we could keep polyfills exportless and side-effecty and use proper modules to power inject which requires default export.

The only reason why you needed to make this change is because in some installations the nightly version got hoisted incorrectly and overshadowed the 1.x version. This resulted in a version skew between the built-time and run-time parts of unenv (built-time was on 1.x which pointed at run-time paths that got resolved @ nightly version causing the problem).

I'd rather think about how to fix the version skew problem than try to align the runtime@head to be compatible with every past version of unenv released.

@pi0
Copy link
Member Author

pi0 commented Jun 18, 2024

@IgorMinar Fix in this PR is not related to hoisted dep at all in this PR. Main entry was not having all ESM named exports (while $cloudflare variant had that's why you probably haven't catched it in your tests but test:node script did)

(regression of #260 solved with #262, that's the one we caught with nightly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants