Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samefile: Cache FileInformation for the target #409

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

tavianator
Copy link
Contributor

And don't follow symlinks.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.55%. Comparing base (f145469) to head (7c8f6f3).

Files Patch % Lines
src/find/matchers/samefile.rs 50.00% 1 Missing and 2 partials ⚠️
src/find/matchers/mod.rs 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #409      +/-   ##
==========================================
- Coverage   65.59%   65.55%   -0.05%     
==========================================
  Files          34       34              
  Lines        3941     3942       +1     
  Branches      901      901              
==========================================
- Hits         2585     2584       -1     
- Misses       1001     1002       +1     
- Partials      355      356       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +4 / SKIP +0 / FAIL -4
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 190 / SKIP: 1 / FAIL: 97
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +4 / FAIL -8 / ERROR +0 / SKIP +0 

@sylvestre
Copy link
Sponsor Contributor

@hanbings wdyt ? :)

Copy link

GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +4 / SKIP +0 / FAIL -4
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 190 / SKIP: 1 / FAIL: 97
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +4 / FAIL -8 / ERROR +0 / SKIP +0 

Copy link

Commit 7c8f6f3 has GNU testsuite comparison:

Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O0 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O1 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O2 is now passing!
Run GNU findutils tests: Congrats! The GNU test samefile-p-brokenlink.new-O3 is now passing!
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +4 / FAIL -8 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +4 / SKIP +0 / FAIL -4
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 190 / SKIP: 1 / FAIL: 97

@sylvestre sylvestre requested a review from hanbings June 28, 2024 07:21
Copy link
Collaborator

@hanbings hanbings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thanks! :)

@hanbings hanbings merged commit fd54f9f into uutils:main Jun 28, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants