Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement -noleaf #414

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Implement -noleaf #414

merged 4 commits into from
Jul 9, 2024

Conversation

hanbings
Copy link
Collaborator

@hanbings hanbings commented Jul 8, 2024

We use the walkdir library for directory traversal in our codebase, and the current predicates are all secondary filtering on the results returned by walkdir. So I guess -noleaf will not bring any optimization (unless walkdir includes this optimization, to be honest I don't know much about walkdir and didn't find any related functions in their documentation).

The current code only contains compatibility code.

Closes #376

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.58%. Comparing base (3bf5567) to head (e9fcdaf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #414      +/-   ##
==========================================
+ Coverage   65.55%   65.58%   +0.03%     
==========================================
  Files          34       34              
  Lines        3942     3952      +10     
  Branches      902      904       +2     
==========================================
+ Hits         2584     2592       +8     
  Misses       1002     1002              
- Partials      356      358       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 8, 2024

Commit 38322c0 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +1 / SKIP +0 / FAIL -1
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 191 / SKIP: 1 / FAIL: 96

@sylvestre
Copy link
Sponsor Contributor

LGTM
Maybe we should create a doc like compatibility.md to keep track of these flags that aren't doing anything but here for compat. WDYT ?

Copy link

github-actions bot commented Jul 8, 2024

Commit e9fcdaf has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +1 / SKIP +0 / FAIL -1
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 191 / SKIP: 1 / FAIL: 96

@hanbings
Copy link
Collaborator Author

hanbings commented Jul 8, 2024

LGTM Maybe we should create a doc like compatibility.md to keep track of these flags that aren't doing anything but here for compat. WDYT ?

Sound like a perfect idea, we cannot assume that every user will review the code to determine compatibility.
I'll submit them in a new PR later. :)

@sylvestre sylvestre merged commit 9c11f11 into uutils:main Jul 9, 2024
19 checks passed
@hanbings hanbings deleted the implement-376 branch July 14, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement -noleaf
2 participants