Switch to licenseclassifier/v2 #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is failing linting (gofmt -s). Signed-off-by: Stephen Kitt <[email protected]>
depguard has switch from a deny list to an allow list, so it rejects everything by default. Since depguard wasn't previously configured to deny anything, this disables it entirely (no linting is lost). Signed-off-by: Stephen Kitt <[email protected]>
This greatly improves the classifier's accuracy, and avoids having to handle the license database in lichen (it's embedded in the classifier). The classifier returns "Copyright" matches, which is a behaviour change for lichen, so these matches are ignored. licenseclassifier/v2 requires Go 1.18 or later, so this drops 1.17 from CI. Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
licenseclassifier-v2
branch
from
3b72282
to
c2a4b85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This greatly improves the classifier's accuracy, and avoids having to handle the license database in lichen (it's embedded in the classifier).
The classifier returns "Copyright" matches, which is a behaviour change for lichen, so these matches are ignored.