Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement magic link login for student accounts #4108

Draft
wants to merge 10 commits into
base: v3
Choose a base branch
from

Conversation

sjschlapbach
Copy link
Member

No description provided.

Copy link

cypress bot commented May 2, 2024

2 failed tests on run #2251 ↗︎

2 35 0 0 Flakiness 0

Details:

Merge 080aaa0 into dce9263...
Project: klicker-uzh Commit: 4ccbec4797 ℹ️
Status: Failed Duration: 07:01 💡
Started: Jul 9, 2024 9:42 PM Ended: Jul 9, 2024 9:49 PM
Failed  H-practice-quiz-workflow.cy.ts • 1 failed test

View Output

Test Artifacts
Different practice quiz workflows > Test scheduling and publishing functionalities of a practice quiz Test Replay Screenshots
Failed  K-group-activity-workflow.cy.ts • 1 failed test

View Output

Test Artifacts
Create and solve a group activity > grade the seeded group acivity Screenshots

Review all test suite changes for PR #4108 ↗︎

@coveralls
Copy link

coveralls commented May 2, 2024

Coverage Status

coverage: 68.056%. remained the same
when pulling 3c39cac on MagicLinkStudentLogin
into 76584a3 on v3.

Copy link

sonarcloud bot commented May 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

gitguardian bot commented Jul 5, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
1509427 Triggered Generic Password ac6aee8 cypress/cypress.config.ts View secret
1509427 Triggered Generic Password ac6aee8 cypress/cypress.config.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants