Remove pass by reference in function definition.

vanderbilt-redcap · Mar 16, 2023 · b59236f · b59236f
1 parent dced636
commit b59236f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/CrossprojectpipingExternalModule.php b/CrossprojectpipingExternalModule.php
@@ -1131,14 +1131,14 @@ function processDataTransfer($currentData,$dst_rid,$src_project,$eid,$field_data
             }
 
             if (!empty($dst_name)) {
-                $this->updateDestinationData($currentData,$destProj,$dst_name,$field_value,$dst_rid,$dst_event_id,$repeat_instance);
+                $currentData = $this->updateDestinationData($currentData,$destProj,$dst_name,$field_value,$dst_rid,$dst_event_id,$repeat_instance);
             }
         }
 
         return $currentData;
     }
 
-    function updateDestinationData(&$destData,\Project $destProject, $destFieldName, $srcFieldValue, $destRecord, $destEvent,$destRepeat = 1) {
+    function updateDestinationData($destData,\Project $destProject, $destFieldName, $srcFieldValue, $destRecord, $destEvent,$destRepeat = 1) {
         $destMeta = $destProject->metadata;
         $destEventForms = $destProject->eventsForms[$destEvent];
 
@@ -1162,6 +1162,7 @@ function updateDestinationData(&$destData,\Project $destProject, $destFieldName,
                 $destData[$destRecord][$destEvent][$destFieldName] = $srcFieldValue;
             }
         }
+        return $destData;
     }
 
 	function getProjectRecordIDs($project_id, $filter_logic = null) {