Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Compatibility" field from package card. #154

Merged
merged 8 commits into from
May 1, 2024

Conversation

JavierMatosD
Copy link
Contributor

@JavierMatosD JavierMatosD commented Apr 4, 2024

This PR is in response to microsoft/vcpkg#37493

The "Compatibility" field in the package card:
image

Is currently based on whatever is in ci.baseline.txt. It assumes the package is compatible with every triplet combination not listed in ci.baseline.txt. This is inaccurate since ci.baseline.txt asserts non-compatibility. It cannot be used to assert compatibility.

Rather than trying a more complicated approach that maps the supports expression to triplets, I opted for removing the Compatibility field all together. The real fix is to use our latest ci run to report actual results. I will do this work on a different PR.

@JavierMatosD JavierMatosD marked this pull request as ready for review April 4, 2024 19:29
@JavierMatosD JavierMatosD merged commit 21336e2 into vcpkg:main May 1, 2024
1 check passed
@JavierMatosD JavierMatosD deleted the fix_compat branch June 20, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants