Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rails 7.1 #62

Closed
wants to merge 2 commits into from

Conversation

caseyprovost
Copy link

No description provided.

@jscharf
Copy link

jscharf commented Oct 6, 2023

Thanks for opening this! We need this change as well so let me know if there's anything I can do to help work on it 🙌

@caseyprovost
Copy link
Author

Thanks for opening this! We need this change as well so let me know if there's anything I can do to help work on it 🙌

Any polishing and cleanup on this PR would be quite welcome. The lower the friction to merge the faster we all win 🎊

@pnicholls
Copy link

pnicholls commented Oct 8, 2023

@caseyprovost is this required? main...wrapbook:activejob-uniqueness:chores/rails-71-upgrade#diff-596b513edba5e668d4270948322cf9737d32534c794d3e9e577ce78da6d5625cR32

  spec.add_dependency 'redis', '~> 4.8.1'

Thanks for kicking this work off btw.

@caseyprovost
Copy link
Author

caseyprovost commented Oct 9, 2023

@caseyprovost is this required? main...wrapbook:activejob-uniqueness:chores/rails-71-upgrade#diff-596b513edba5e668d4270948322cf9737d32534c794d3e9e577ce78da6d5625cR32

  spec.add_dependency 'redis', '~> 4.8.1'

Thanks for kicking this work off btw.

I was getting file not found "redis" when trying to run the tests otherwise. It's possible I wasn't doing it properly though 🤔

@jscharf jscharf mentioned this pull request Oct 12, 2023
@jscharf
Copy link

jscharf commented Oct 12, 2023

Was just looking at #63 and the author made a change to the Appraisals file.

Is anyone familiar with that file can comment on whether it's needed as part of the support for Rails 7.1?

@bforma
Copy link

bforma commented Oct 13, 2023

Is anyone familiar with that file can comment on whether it's needed as part of the support for Rails 7.1?

Yes, you will have to add 7.1 support in the Appraisals file, like I did in my #63 PR.

@laurafeier
Copy link
Contributor

Since the upgrade of redlock, we don't need redis anymore. I updated the specs to use redis-client, which is the current redlock dependency. See #65 #66

@sharshenov
Copy link
Member

@caseyprovost thank you for the effort

I'm closing this Draft in favor of #66

@sharshenov sharshenov closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants