Split ast-to-sst code out of func_to_air and into ast_to_sst_func #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd also like to rename |
utaal
approved these changes
Jul 7, 2024
tjhance
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just moves some code around so that the AST-to-SST code is in a separate file (ast_to_sst_func.rs) from the SST-to-AIR code in func_to_air.rs. I think this makes func_to_air.rs easier to understand, since it now operates just on vir::sst::Exp and air::ast::Expr, without involving vir::ast::Expr.
I'm thinking of this as an initial step towards a simpler, more cohesive AST-to-SST translation, but I'd like to merge this initial step first so that the later steps are clearer and easier to review.