Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10 + updated dependencies #120

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rnbwdsh
Copy link

@rnbwdsh rnbwdsh commented Aug 7, 2022

Update requirements to 2022-08-08
Create easy runner command for linux/mac
Update readme

@rnbwdsh rnbwdsh mentioned this pull request Aug 7, 2022
@rnbwdsh
Copy link
Author

rnbwdsh commented Aug 15, 2022

[moved to issue]

Comment on lines +1 to +3
#!/usr/bin/env bash
FILE=$(readlink "$0" || echo "$0")
DIR=$(dirname $FILE)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be done in a more POSIX compatible way with:

#!/usr/bin/env sh
DIR="$(CDPATH= cd -- "$(dirname -- "$0")" && pwd -P)"

While readlink tends to be available on GNU, Busybox, & BSD/OS X systems, it's non-standard & flags differ between them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.

dvmarkusvogl added a commit to dvmarkusvogl/vial-gui that referenced this pull request Oct 5, 2022
Thundernerd added a commit to Thundernerd/vial-gui that referenced this pull request Jan 8, 2023
@emrysr
Copy link

emrysr commented Jan 26, 2023

Thanks for this!! fbs run works perfectly in MacBook(2016) v12.6.2 with python Python 3.10.9
fbs freeze builds, but this error is shown when I run Vial:-

Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'

@lesshonor
Copy link
Contributor

lesshonor commented Mar 7, 2023

FWIW, the appimage this builds dumps core on my Arch install. Something packaging-related (missing libqxcb.so?) as I have no issues running target/Vial/Vial. May be a matter of updating pkg2appimage. I'll poke at it again some other time soon.

Would be a good idea to switch to pypi's hidapi package too -- xyz mentioned it was forked because of the 3.6 dependency. The older version won't build on your average Windows box without jumping through some annoying VC++ dependency hoops (...didn't feel like doing this so I just installed current from pip)

Which brings me to my main point -- think I've managed to fix the Windows build by updating Vial's configuration to match fbs's current defaults (plus a few extras). I'll bang on it for a week to see if anything breaks and then submit a PR to your branch with details.

Thanks for this!! fbs run works perfectly in MacBook(2016) v12.6.2 with python Python 3.10.9 fbs freeze builds, but this error is shown when I run Vial:-

Fatal Python error: init_fs_encoding: failed to get the Python codec of the filesystem encoding
Python runtime state: core initialized
ModuleNotFoundError: No module named 'encodings'

Google tells me this may be a venv issue. Try recreating yours, just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants