Export layout as svg #132
Open
Export layout as svg #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groig
force-pushed
the
main
branch
2 times, most recently
from
0d5f1e3
to
b69f857
Compare
groig
force-pushed
the
main
branch
2 times, most recently
from
8b878f6
to
1a4f8db
Compare
|
More output examples Lily58
|
|
Alpha
|
|
B Slides
|
|
Crbn
|
|
Louhi
|
|
Reviung34
|
|
This is sweet. I'm not in core, so take my suggestions with a grain of salt:
Is there something non core contributors can do to move this forward? |
|
@kbrock Done and done. |
NCKiser
reviewed
Nov 6, 2023
| generator.setSize(QSize(widget.width, widget.height * self.keyboard.layers)) | ||
| generator.setViewBox(QRect(0, 0, widget.width, widget.height * self.keyboard.layers)) | ||
| generator.setFileName(filename) | ||
| generator.setTitle("My Keymap") |
There was a problem hiding this comment.
Use keyboard name here, as it appears in the keyboard selector dropdown
NCKiser
reviewed
Nov 6, 2023
| generator.setViewBox(QRect(0, 0, widget.width, widget.height * self.keyboard.layers)) | ||
| generator.setFileName(filename) | ||
| generator.setTitle("My Keymap") | ||
| generator.setDescription("Keymap generated from Vial") |
|
Any chance this could be merged? would be a very useful feature to have. |
II haven't had time to implement the changes requested by @NCKiser. If they are blocking, somebody else can give it a go, maybe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for showing the layout in readmes and blog posts
Example output