Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Any dialog modifier abilities #176

Open
wants to merge 2 commits into
base: new-keycodes
Choose a base branch
from

Conversation

NCKiser
Copy link
Contributor

@NCKiser NCKiser commented May 1, 2023

Adds a "Modifiers" checkbox to the Any key dialog which is only enabled when the keycode is Basic, Mod-Tap, or OSM.

image
image

When "Modifiers" is checked, the keycode is stripped down to its basic component, and the other components are reflected in the new toggles. The resulting keycode is shown in along the bottom of the window.

image

When the "One-Shot Mod" toggle is checked, the keycode text field is disabled.

image

When the text field is not a valid keycode, the text field will be preserved, and the new toggles will default off when switching between "Modifiers" mode and standard Any-key mode.

image

image

@lesshonor
Copy link
Contributor

lesshonor commented May 16, 2023

We talked about this in Discord, but just to make it public...

It needs to do some more edge-case policing, I think.
0x6001

With no modifiers actually selected, it'd make more sense to still show KC_TRNS/0x0001 as the computed keycode/value.

@NCKiser
Copy link
Contributor Author

NCKiser commented May 17, 2023

That is a good point, thank you for bringing this up. I will test and implement more edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants