Pyinstaller branch rebase and fbs removal #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbs was holding back the code from using modern versions of python, qt, and everything else. Remove fsb and update everything. * Remove fbs from spec * update to python 3.12 * update all dependencies to latest minor releases * update to latest version of pyinstaller * re-implement part of fbs context object to minimize refactoring * update Vial.spec to have all options necessary to run
dwlocks
force-pushed
the
pyinstaller-rebase
branch
2 times, most recently
from
721338d
to
0794bcc
Compare
dwlocks
force-pushed
the
pyinstaller-rebase
branch
from
0794bcc
to
9d4067d
Compare
|
Anecdotally, this seems to work on Linux for me. The Vial window opens, I can change key mappings on the keyboard, unlock the keyboard and run the matrix tester, save/load the keyboard layout. |
|
I am still having issues with vial recognizing my via-configured keyboard, so I haven't even been able to test beyond "software builds and runs". |
|
I managed to build this on a Mac but seems like it keeps opening new windows for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased that branch onto head, updated python to 3.12, updated Qt5 to latest, and allowed all dependencies to update accordingly. Then i removed FBS and implemented the minimum I could see that was needed to run (on windows).
This involved adding a couple json to the Vial.spec, some code to load those files, and the minimum possible amount of refactoring. There's more code that could be simplified with FBS gone, but I didn't want to go too far before getting some input and maybe getting someone to test on linux. I haven't kept a full vm handy for a couple years now...