Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for reviung53 #440

Merged
merged 11 commits into from
May 1, 2023
Merged

Add support for reviung53 #440

merged 11 commits into from
May 1, 2023

Conversation

DPoplin
Copy link
Contributor

@DPoplin DPoplin commented Apr 11, 2023

This PR adds a Reviung53 vial directory and keymap files.

@DPoplin DPoplin marked this pull request as ready for review April 11, 2023 18:21
@DPoplin
Copy link
Contributor Author

DPoplin commented Apr 17, 2023

Requested changes have been resolved. Please let me know if you need anything else

keyboards/reviung/reviung53/readme.md Outdated Show resolved Hide resolved
keyboards/reviung/reviung53/keymaps/vial/config.h Outdated Show resolved Hide resolved
@DPoplin
Copy link
Contributor Author

DPoplin commented Apr 19, 2023

Requested changes should now be correctly implemented -- Firmware compiles

@DPoplin DPoplin changed the title Add reviung53 vial directory Add support for reviung53 Apr 19, 2023
@xyzz xyzz merged commit 06d2174 into vial-kb:vial May 1, 2023
@DPoplin DPoplin deleted the add-reviung53 branch May 15, 2023 15:56
lesshonor added a commit to lesshonor/vial-qmk that referenced this pull request May 18, 2023
* add reviung53 vial files

* add newlines at file end

* remove VIAL_INSECURE from rules.mk

* Update keyboards/reviung/reviung53/keymaps/vial/rules.mk

Co-authored-by: Less/Rikki <[email protected]>

* Delete readme.md

* Revert "Delete readme.md"

This reverts commit acad8ef.

* add unlock code

* remove comments

---------

Co-authored-by: Less/Rikki <[email protected]>
lesshonor added a commit to lesshonor/vial-qmk that referenced this pull request May 18, 2023
* add reviung53 vial files

* add newlines at file end

* remove VIAL_INSECURE from rules.mk

* Update keyboards/reviung/reviung53/keymaps/vial/rules.mk

Co-authored-by: Less/Rikki <[email protected]>

* Delete readme.md

* Revert "Delete readme.md"

This reverts commit acad8ef.

* add unlock code

* remove comments

---------

Co-authored-by: Less/Rikki <[email protected]>
lesshonor added a commit to lesshonor/vial-qmk that referenced this pull request May 20, 2023
* add reviung53 vial files

* add newlines at file end

* remove VIAL_INSECURE from rules.mk

* Update keyboards/reviung/reviung53/keymaps/vial/rules.mk

Co-authored-by: Less/Rikki <[email protected]>

* Delete readme.md

* Revert "Delete readme.md"

This reverts commit acad8ef.

* add unlock code

* remove comments

---------

Co-authored-by: Less/Rikki <[email protected]>
lesshonor added a commit to lesshonor/vial-qmk that referenced this pull request Jun 15, 2023
* add reviung53 vial files

* add newlines at file end

* remove VIAL_INSECURE from rules.mk

* Update keyboards/reviung/reviung53/keymaps/vial/rules.mk

Co-authored-by: Less/Rikki <[email protected]>

* Delete readme.md

* Revert "Delete readme.md"

This reverts commit acad8ef.

* add unlock code

* remove comments

---------

Co-authored-by: Less/Rikki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants