Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing layer dip switch code for Keychron V2 #447

Merged
merged 2 commits into from
May 1, 2023

Conversation

adophoxia
Copy link
Contributor

As title.

@xyzz
Copy link
Contributor

xyzz commented Apr 30, 2023

It fails to compile

@adophoxia
Copy link
Contributor Author

Saw that I forgot to add #if defined(RGB_MATRIX_ENABLE) && defined(CAPS_LOCK_LED_INDEX) at the start of the process_record_kb function. Compiles fine now.

@xyzz xyzz merged commit 6bea951 into vial-kb:vial May 1, 2023
@adophoxia adophoxia deleted the keychron-v2-dip-fix branch May 3, 2023 00:45
lesshonor pushed a commit to lesshonor/vial-qmk that referenced this pull request May 18, 2023
* Add missing layer `dip switch` for Keychron V2

* Add missing `#if defined` block in `v2.c`
lesshonor pushed a commit to lesshonor/vial-qmk that referenced this pull request May 18, 2023
* Add missing layer `dip switch` for Keychron V2

* Add missing `#if defined` block in `v2.c`
lesshonor pushed a commit to lesshonor/vial-qmk that referenced this pull request May 20, 2023
* Add missing layer `dip switch` for Keychron V2

* Add missing `#if defined` block in `v2.c`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants