Update and add Budget96 support #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesshonor
suggested changes
Apr 27, 2023
There was a problem hiding this comment.
I wouldn't bother modifying this file; the pending merge from upstream already makes this change and more. Updating it now will cause a conflict.
There was a problem hiding this comment.
Ok I think I managed to properly remove the commit for that file so it should just be the map updates now.
lesshonor
approved these changes
Apr 27, 2023
Co-authored-by: Less/Rikki <[email protected]>
lesshonor
suggested changes
Apr 28, 2023
Co-authored-by: Less/Rikki <[email protected]>
lesshonor
added a commit
to lesshonor/vial-qmk
that referenced
this pull request
May 18, 2023
* Add Vial-enabled default map to budget96 * Update rules.mk via suggestion Co-authored-by: Less/Rikki <[email protected]> * Suggestions to keymap.c Co-authored-by: Less/Rikki <[email protected]> --------- Co-authored-by: Less/Rikki <[email protected]>
lesshonor
added a commit
to lesshonor/vial-qmk
that referenced
this pull request
May 18, 2023
* Add Vial-enabled default map to budget96 * Update rules.mk via suggestion Co-authored-by: Less/Rikki <[email protected]> * Suggestions to keymap.c Co-authored-by: Less/Rikki <[email protected]> --------- Co-authored-by: Less/Rikki <[email protected]>
lesshonor
added a commit
to lesshonor/vial-qmk
that referenced
this pull request
May 20, 2023
* Add Vial-enabled default map to budget96 * Update rules.mk via suggestion Co-authored-by: Less/Rikki <[email protected]> * Suggestions to keymap.c Co-authored-by: Less/Rikki <[email protected]> --------- Co-authored-by: Less/Rikki <[email protected]>
lesshonor
added a commit
to lesshonor/vial-qmk
that referenced
this pull request
Jun 15, 2023
* Add Vial-enabled default map to budget96 * Update rules.mk via suggestion Co-authored-by: Less/Rikki <[email protected]> * Suggestions to keymap.c Co-authored-by: Less/Rikki <[email protected]> --------- Co-authored-by: Less/Rikki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Budget96 to remove deprecated
RGBLIGHT_ENABLEand addition of Vial-enabled default map,