Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scanner: provide device name #183

Merged
merged 2 commits into from
Mar 19, 2024
Merged

scanner: provide device name #183

merged 2 commits into from
Mar 19, 2024

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Mar 18, 2024

This PR uses the http interface at 8008:setup/eureka_info to pick out the device name, if a device has been found via scanning.

$ go run .  scan --cidr 192.168.50.0/24 
Scanning...  scanned 0, current 192.168.50.0
  - 'Office speaker' at 192.168.50.88:8009
Scanned 256 uris in 1.609840334s

Also removes some leftovers from a previous PR.

@vishen
Copy link
Owner

vishen commented Mar 19, 2024

Thanks for this @holiman!

@vishen vishen merged commit 5494422 into vishen:master Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants