Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search improvements #43

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Search improvements #43

merged 5 commits into from
Jul 5, 2024

Conversation

selankon
Copy link
Collaborator

@selankon selankon commented Jul 5, 2024

Fix #41

  • It enables the search by partial processId only if is valid partial process id string.
  • Fixes also a bug with the debounced imput search, introduced by Improve filter search UX #40
  • It also implements to restore the organization list search query when accessing by url
  • It improves the retryUnlessNotFound to get the AxiosError 404 status code

@selankon
Delete organizationId filter
5277a9d 
See #41 (comment)
@selankon
Search only valid partialId string
970e41d
@selankon
Hotfix debounced input search
5b47708 
It has an error because it was setting the value after debounce, so is wrong behaviour on user side.

Now is using internal state to store the value
@selankon
Improve organization search
300b686
@selankon selankon requested a review from elboletaire July 5, 2024 08:12
@selankon selankon changed the title Implement odd checker Search input improvements Jul 5, 2024
@selankon selankon changed the title Search input improvements Search improvements Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

🚀 Deployed on https://6687abb9101d2c1170ef23cb--vocdoni-explorer-dev.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 08:15 Inactive
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

🚀 Deployed on https://6687abc3db1bcc17ecaff047--vocdoni-explorer-stg.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 5, 2024 08:16 Inactive
@elboletaire elboletaire merged commit 0e0c180 into main Jul 5, 2024
3 checks passed
@elboletaire elboletaire deleted the f/implement-odd-checker branch July 5, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elboletaire elboletaire elboletaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search process by organization id
2 participants
@selankon @elboletaire