Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caching issues in JSON::Util::URI #515

Merged
merged 16 commits into from
Aug 19, 2024
Merged

Fix caching issues in JSON::Util::URI #515

merged 16 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. Reproduce caching issue with the JSON::Util::URI.normalize_ref method

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f8138c0 View commit details
    Browse the repository at this point in the history

  2. Use singleton class to define methods in URI

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7dd8e5a View commit details
    Browse the repository at this point in the history

  3. Add caching to JSON::Util::URI.unescaped_path method 

    I decided not to re-raise the `Addressable::URI::InvalidURIError`, which was originally re-raised
as `JSON::Schema::UriError`. This decision was made because the subsequent call
to `Addressable::URI.unescape(uri)` does not handle these errors, requiring the user to handle
both types of errors.

Given that any call to the Addressable gem could potentially lead to an error, and
the JSON Schema gem does not consistently wrap them as `JSON::Schema::UriError`,

I decided to simplify the code for now. Error handling can be added later if necessary.
    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    299091a View commit details
    Browse the repository at this point in the history

  4. Add caching to JSON::Util::URI.file_uri method

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    f215843 View commit details
    Browse the repository at this point in the history

  5. Move URI.unescape_uri to URI2.unescape

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8b1b616 View commit details
    Browse the repository at this point in the history

  6. Replace URI.unescaped_path with URI.unescape_path

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    54f7189 View commit details
    Browse the repository at this point in the history

  7. Replace URI.file_uri with URI2.file_uri

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    c515f74 View commit details
    Browse the repository at this point in the history

  8. Replace URI.strip_fragment with URI2.strip_fragment

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    88c1a21 View commit details
    Browse the repository at this point in the history

  9. Replace URI.normalized_uri with URI2.normalize_uri

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a9b6c7f View commit details
    Browse the repository at this point in the history

  10. Replace URI.normalize_ref with URI2.normalize_ref

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    1089144 View commit details
    Browse the repository at this point in the history

  11. Use URI2.absolutize_ref instead of URI.absolutize_ref

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    8833925 View commit details
    Browse the repository at this point in the history

  12. Use URI2.parse instead of URI2.parse

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    0cc71ab View commit details
    Browse the repository at this point in the history

  13. Rename URI2 to URI

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7c5d323 View commit details
    Browse the repository at this point in the history

  14. Rename methods back to reduce diff

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a16e11b View commit details
    Browse the repository at this point in the history

  15. Revert "Reproduce caching issue with the JSON::Util::URI.normalize_re… 

    …f method"

This reverts commit 401f707.
    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    e476b07 View commit details
    Browse the repository at this point in the history

  16. Update lib/json-schema/util/uri.rb

    @bolshakov @bastelfreak
    bolshakov authored and bastelfreak committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    2ad9e19 View commit details
    Browse the repository at this point in the history