Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev deps: Add strict version contraints & CI: build gem with strict mode & CI: Use Ruby 3.3 for releases #525

Merged
merged 4 commits into from
Aug 19, 2024
Merged

dev deps: Add strict version contraints & CI: build gem with strict mode & CI: Use Ruby 3.3 for releases #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2cc7fc
dev deps: Add strict version contraints
bastelfreak Aug 19, 2024
bd71aca
CI: build gem with strict mode
bastelfreak Aug 19, 2024
e653a06
CI: Use Ruby 3.3 for releases
bastelfreak Aug 19, 2024
8fe0c3f
gemspec: remove homepage_uri
bastelfreak Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
if: github.repository_owner == 'voxpupuli'
steps:
- uses: actions/checkout@v4
- name: Install Ruby 3.1
- name: Install Ruby 3.3
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.1'
ruby-version: '3.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In another place I've been lazy and just used Ruby 3. Is that something we want here as well?

Suggested change
ruby-version: '3.3'
ruby-version: '3'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I don't know under which conditions they will bump that version. I only bump the version in the release action when we've the same version in a test and it passes.

- name: Build gem
run: gem build *.gemspec
run: gem build --strict --verbose *.gemspec
- name: Publish gem to rubygems.org
run: gem push *.gem
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- name: Run tests
run: bundle exec rake ${{ matrix.rake_task }} RUBYOPT="${{ matrix.rubyopt }}"
- name: Build gem
run: gem build *.gemspec
run: gem build --strict --verbose *.gemspec
tests:
needs:
- test
Expand Down
7 changes: 3 additions & 4 deletions json-schema.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Gem::Specification.new do |s|
s.metadata = {
'source_code_uri' => s.homepage,
'changelog_uri' => "#{s.homepage}/blob/master/CHANGELOG.md",
'homepage_uri' => s.homepage,
'bug_tracker_uri' => "#{s.homepage}/issues",
}
s.summary = 'Ruby JSON Schema Validator'
Expand All @@ -18,9 +17,9 @@ Gem::Specification.new do |s|
s.license = 'MIT'

s.add_development_dependency 'minitest', '~> 5.0'
s.add_development_dependency 'rake'
s.add_development_dependency 'rake', '~> 13.0'
s.add_development_dependency 'voxpupuli-rubocop', '~> 2.8.0'
s.add_development_dependency 'webmock'
s.add_development_dependency 'webmock', '~> 3.23'

s.add_runtime_dependency 'addressable', '>= 2.8'
s.add_runtime_dependency 'addressable', '~> 2.8'
end