Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add server parameter on collectd::plugin::network::server #995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fe80
Copy link
Contributor

@fe80 fe80 commented Mar 28, 2022

Hello,

I've actually a profile class with a Collectd::Plugin::Network::Server. My collectd can be overwrite by anybody, and my profil class can't be detect which old network file it's require to clean if I not create a new resource with absent statement.

I would like to manage this plugin with a fixed file name and define the server with a separated parameter.

Pull Request (PR) description

This feature include the possibility to add a specific title on collectd::plugin::network::server for the configuration file name. The server should be define with the server option.

This Pull Request (PR) fixes the following issues

spec/defines/collectd_plugin_network_server_spec.rb Outdated Show resolved Hide resolved
manifests/plugin/network/server.pp Outdated Show resolved Hide resolved
spec/defines/collectd_plugin_network_server_spec.rb Outdated Show resolved Hide resolved
spec/defines/collectd_plugin_network_server_spec.rb Outdated Show resolved Hide resolved
This feature include the possibility to add a specific title on
`collectd::plugin::network::server` for the configuration file name. The
server should be define with the `server` option.
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex added the enhancement New feature or request label Mar 28, 2022
@traylenator
Copy link
Contributor

Hi

Could you rebase this. Arch support has been removed so that faling test will no longer exist.

Adding a needs-rebase tag, please remove once done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants