Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh service after package change (upgrade or downgrade) #251

Closed
wants to merge 1 commit into from
Closed

Refresh service after package change (upgrade or downgrade) #251

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2015

This is to address issue reported at
#215.

We now refresh logstash service everytime there is a package change.
This is particulary useful when upgrading.

This is to address issue reported at
#215.

We now refresh logstash service everytime there is a package change.
This is particulary useful when upgrading.
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@ghost
Copy link
Author

ghost commented Nov 12, 2015

CLA was signed.

@elasticsearch-release
Copy link

Can one of the admins verify this patch?

@joshuaspence
Copy link
Contributor

+1

@dutsmiller
Copy link

Is this going to be merged at some point. Without the change, upgrading is not fully automated.

@jarpy
Copy link
Contributor

jarpy commented Jul 18, 2016

I don't think so. This PR is a merge conflict now. It's not a great story, but it's a victim of the long period of low activity on this module. :(

What we really need is a new implementation, with acceptance coverage to prove that it works, and that it stays working.

@jarpy jarpy closed this Jul 18, 2016
@karmi
Copy link

karmi commented Jul 18, 2016

Hi @VonFreud, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants