Add local mode and remove deprecated http_instance call #16
Conversation
| end | ||
|
|
||
| def lookup(path, vault_url = nil) | ||
| def lookup(path, vault_url = nil, local_token = false, local_token_file = '/etc/vault.token') |
There was a problem hiding this comment.
@tuxmaster5000 have you considered in adding in support for Hashicorp environment variables?
I'm not sure of your use case, but I think that adding support similar to what is already present for VAULT_ADDR might be a better approach than expanding the argument list here.
There was a problem hiding this comment.
As far I understood the link, the variable store the token itself. But my idea was to add an option the load the token from an file.
There was a problem hiding this comment.
I suggested following support for some of the Hashicorp environment variables because it seems like a good idea to follow some of the standard ways Hashicorp supports reading in the token. If we are going to add support for it as a method argument, it might be a good idea to add support reading it from the environment as well? There is already a pattern for reading in the vault_url from the ENV, and I think it would be good to extend that pattern.
There was a problem hiding this comment.
In this implementation, the code is setting a default location for the token file to be in /etc/vault.token, but the standard place is often ~/.vault-token. Is this the reason for splitting local_token and local_token_file, so we can set that default location? I'm not sure we need to provide that default here, but I'd like to hear why the code is written that way.
|
@tuxmaster5000 there was a change commited to master that fixes the failing CI tests; can you rebase your PR onto master so we can have results from CI updated for this? Thanks! |
|
Dear @tuxmaster5000, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Dear @tuxmaster5000, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Because you have change the master to much I can't fix it. So please overtake it. |
This Pull Request (PR) fixes the following issues