Remove unsupported OS #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please rebase against our master branch to get rid of the merge commit? |
Valantin
force-pushed
the
del/unsupported
branch
8 times, most recently
from
5efacc7
to
cd6af3e
Compare
bastelfreak
reviewed
Jun 28, 2024
| case $facts['os']['family'] { | ||
| 'RedHat': { | ||
| $majorrelease = $facts['os']['release']['major'] | ||
| if (versioncmp(fact('os.release.major'), '7') >= 0 and $zabbix_version == '7.0') { |
There was a problem hiding this comment.
you can use $majorrelease here
Suggested change
| if (versioncmp(fact('os.release.major'), '7') >= 0 and $zabbix_version == '7.0') { | |
| if (versioncmp($majorrelease, '7') >= 0 and $zabbix_version == '7.0') { |
bastelfreak
reviewed
Jun 28, 2024
| "7", | ||
| "8" | ||
| ] | ||
| }, | ||
| { | ||
| "operatingsystem": "CentOS", | ||
| "operatingsystemrelease": [ | ||
| "7", |
There was a problem hiding this comment.
CentOS 7 is also EoL: https://voxpupuli.org/blog/2024/05/08/CentOS-7-CentOS-Stream-8-deprecation/
There was a problem hiding this comment.
Yes I'v planned to remove EL7 code and OS in a separe PR, need to remove a lot of unused logic from manifest and spec
Valantin
force-pushed
the
del/unsupported
branch
from
90b9e9c
to
dd89546
Compare
Set manage_startup_script to false on OS that provide correct systemd unit in package
Valantin
force-pushed
the
del/unsupported
branch
from
dd89546
to
f00c8c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Remove unsupported os
This Pull Request (PR) fixes the following issues
#954