Updated comments per review comments, and modified dilatancy factor n…

…ame in the tests ref# 184
vprithiv · Feb 23, 2023 · 4847b2d · 4847b2d
1 parent 50a3424
commit 4847b2d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/doc/content/bib/blackbear.bib b/doc/content/bib/blackbear.bib
@@ -256,11 +256,11 @@ @article{lee1998plastic
   publisher={American Society of Civil Engineers}
 }
 
-@book{lee1996theory,
+@phdthesis{lee1996theory,
   title={Theory and implementation of plastic-damage model for concrete structures under cyclic and dynamic loading},
   author={Lee, Jeeho},
   year={1996},
-  publisher={University of California, Berkeley}
+  school={University of California, Berkeley}
 }
 
 @article{wilkins2020method,

diff --git a/doc/content/source/materials/ComputeMultipleInelasticDamageStress.md b/doc/content/source/materials/ComputeMultipleInelasticDamageStress.md
@@ -4,8 +4,12 @@
 
 ## Description
 
-This class `ComputeMultipleInelasticDamageStress` computes the stress with the damage obtained from 
-  the previous time step. This is done mainly to avoid convergence problems
+`ComputeMultipleInelasticDamageStress` is a class based on `ComputeMultipleInelasticStress`
+that is designed specifically to be used with [DamagePlasticityStressUpdate](DamagePlasticityStressUpdate.md).
+The main difference between this class and the standard `ComputeMultipleInelasticStress` class is that
+it makes some modifications to both the current and old stress to account for the damage in a way that
+is appropriate for the damaged plasticity model. It divides the old stress passed to the plasticity model
+by $(1-D)$, and multiplies the new stress by $(1-D)$, where $D$ is the damage index.
 
 This ComputeMultipleInelasticStress is to be used with (/DamagePlasticityStressUpdate.md).
 ## Example Input Files

diff --git a/src/materials/DamagePlasticityStressUpdate.C b/src/materials/DamagePlasticityStressUpdate.C
@@ -538,7 +538,7 @@ DamagePlasticityStressUpdate::ft(const std::vector<Real> & intnl) const
   if (_zt > sqrtPhi_t / _at)
     return _ft0 * std::pow(_zt - sqrtPhi_t / _at, (1. - _dt_bt)) * sqrtPhi_t;
   else
-    return _ft0 * 1.E-6;
+    return _ft0 * 1.E-6; //A very small number (instead of zero) is used for end of softening
 }
 
 Real

diff --git a/test/tests/damage_plasticity_model/tests b/test/tests/damage_plasticity_model/tests
@@ -41,7 +41,7 @@
       cli_args = 'BCs/x_r/function=-2E-5*x*t
                   Executioner/end_time=500
                   Executioner/dt=10
-                  Materials/damage_plasticity_model/factor_controlling_dilatancy=0.30
+                  Materials/damage_plasticity_model/dilatancy_factor=0.30
                   Outputs/file_base=dilatancy_out'
       detail = ' when factor_controlling_dilatancy is changed.'
     []