Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] valueCount for array mipmaps read from vsg::Data #955

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

siystar
Copy link

@siystar siystar commented Sep 4, 2023

Pull Request Template

Description

Added vsg::computeValueCount used in CopyAndReleaseImage / TransferTask to get the correct value count for layered, mipmapped image data.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested converting 2D images to 2D image array.

Tested vsgvalidate array_data_mipmaps:

info: array_data_mipmaps test passed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@robertosfield
Copy link
Collaborator

I have done a couple of passes over the changes and they are quite extensive so it's not easy for me to quickly review, understand the motivation of all the changes and make a decision about whether it achieves the aims and doesn't have cause any unintended regressions.

I am really busy this week so don't have days I can devote to reviewing and testing community submissions - I poured all my available time into this last week so have to get back to all the work delayed by this. Once I have tackled this work I'll pop back onto reviewing submissions.

If submissions are narrow and can be easily reviewed and tested then I'll look at merging these. So if there are parts of this submission can be spun out then this would help make the review and testing tasks easily to fit in. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants