Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements SSL-EY #378

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

jameschapman19
Copy link

Adding SSL-EY from (https://arxiv.org/abs/2310.01012, https://neurips.cc/virtual/2023/80864)

For the moment I've implemented the simple version but it should in principle plug into multicrop like SWAV.

Will have a stab at running the shorter benchmarks shortly.

@vturrisi
Copy link
Owner

vturrisi commented Dec 6, 2023

hey @jameschapman19 thanks for contributing. I'll try to start checking your code soon.

@@ -0,0 +1,81 @@
defaults:
- _self_
- augmentations: ssley.yaml
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have the augmentations below, either remove this or move the augmentations to a separate file (both are fine)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot - a heads up I think this is also the case for scripts/pretrain/imagenet-100/vicreg.yaml in that case.

This method should plug in wherever VICReg is used. In many ways the benefit of the loss function is it's got a lot of the nice properties of VICReg but without needing to tune the three loss function parameters.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why VICReg is like that haha. I'm fine with having a separate file for the augmentations or having it merged with the main file. Should also prob fix VICReg after that.

@vturrisi vturrisi self-assigned this Dec 6, 2023
@jameschapman19
Copy link
Author

@vturrisi - just working through ironing things out perhaps a premature PR I just wanted to get a hang of the CI. Will give you a shout when I'm passing more of these.

@vturrisi
Copy link
Owner

vturrisi commented Dec 6, 2023

@jameschapman19 no worries, take your time :) and ping me when you are done

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #378 (9e8ad7e) into main (0eadf3d) will increase coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 93.75%.

❗ Current head 9e8ad7e differs from pull request most recent head 11eac92. Consider uploading reports for the commit 11eac92 to get more accurate results

Additional details and impacted files
Flag Coverage Δ *Carryforward flag
cpu 80.02% <93.75%> (+0.15%) ⬆️
dali 38.81% <ø> (ø) Carriedforward from 0eadf3d

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
solo/losses/__init__.py 100.00% <100.00%> (ø)
solo/methods/__init__.py 100.00% <100.00%> (ø)
solo/methods/ssley.py 100.00% <100.00%> (ø)
solo/losses/ssley.py 75.00% <75.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants