Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encourage purpose-built APIs, fix #175 #295

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Encourage purpose-built APIs, fix #175 #295

merged 2 commits into from
Jun 28, 2023

Conversation

darobin
Copy link
Member

@darobin darobin commented Jun 28, 2023 •
edited by pr-preview bot
Loading

@darobin darobin requested a review from npdoty June 28, 2023 15:32
npdoty
npdoty approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@npdoty npdoty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darobin darobin merged commit c523776 into main Jun 28, 2023
1 check failed
github-actions bot added a commit that referenced this pull request Jun 28, 2023
@darobin @github-actions
Encourage purpose-built APIs, fix #175 (#295)
7daaf92 
SHA: c523776
Reason: push, by darobin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@npdoty npdoty npdoty approved these changes

@jyasskin jyasskin jyasskin approved these changes

@rhiaro rhiaro rhiaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darobin @npdoty @jyasskin @rhiaro