Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typechain Revived Milestone 1 #1191

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Typechain Revived Milestone 1 #1191

merged 3 commits into from
Jul 17, 2024

Conversation

WookashWackomy
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2289 < please fill this in with the PR number of your application.

@semuelle semuelle self-assigned this Jul 8, 2024
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the delivery, @WookashWackomy. I am currently working my way through the documentation. However, when I run npm i on the example project, I get

> npm i
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @c-forge/typechain-compiler@^0.5.16.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

It looks like the most recent version is 0.2.0, maybe you forgot to publish it?

@WookashWackomy
Copy link
Contributor Author

WookashWackomy commented Jul 11, 2024

Thanks for the delivery, @WookashWackomy. I am currently working my way through the documentation. However, when I run npm i on the example project, I get

> npm i
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @c-forge/typechain-compiler@^0.5.16.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

It looks like the most recent version is 0.2.0, maybe you forgot to publish it?

Hi @semuelle , sorry you've encountered this issue. We've missed the refinement of that particular docs file. It's updated now, additionally couple of fixups made along the way merged in. Regarding version - 0.2.2 is the newest one (reflected in docs). Gonna handle the versioning in milestone 2, during ironing out the last details.

Also, the whole example project that's being laid down in the document you've tried to go through was integrated into the repository. https://github.com/C-Forge/typechain-polkadot/tree/main/examples/typechain-compiler-example.

Should be all good now!

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, I'll try again. Is this line right?

@semuelle
Copy link
Member

Sorry, I am now following the testing guide, and pnpm run test keeps failing with missing packages (fs-extra, handlebars, globby, ...). Did I miss a step?

@WookashWackomy
Copy link
Contributor Author

WookashWackomy commented Jul 16, 2024

Sorry, I am now following the testing guide, and pnpm run test keeps failing with missing packages (fs-extra, handlebars, globby, ...). Did I miss a step?

Hey, as long as you run pnpm i beforehand it should be all good. We've verified that today and the packages install properly for us, I don't really know why would it fail for you. The only thing that come to my mind is that you use npm instead of pnpm and the install command does not install dependencies for workspace packages (hence the behavior you've experienced).

That being said - we've added npm workspace support to support npm <something> workspace wide commands (meaning npm i & npm run test or npm run build --workspaces --if-present will work as well as the mentioned in README.md's pnpm i, pnpm run test or pnpm -r build commands.

If you pull main, run install command and it still's failing - please let me know. Could be something OS/environmental.... If possible over Element (@Lukas7980:matrix.org), telegram: @WookashWackomy or Discord (@WookashWackomy) so I can help better/quicker

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @WookashWackomy, thanks for the fixes. I am happy to report that your milestone is hereby accepted. Other than the minor issue with the testing instructions, everything worked out of the box. Much appreciated! You can find my evaluation notes here.

@semuelle semuelle merged commit 3dd2653 into w3f:master Jul 17, 2024
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Copy link

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants