Custom culture

[Keyros]

Fix #293 #241
Add culture support for MSDN documentation links

Included an option for users to specify their preferred culture for the MSDN documentation links

Now we can define custom culture at config.rsp file

[waf]

Thanks for the PR! From a quick look, it looks good. I'll review this and play around with it later this week.

[Keyros]

Thanks for the PR! From a quick look, it looks good. I'll review this and play around with it later this week.

Hi, is there any news on the pull request?

[waf]

Just some minor feedback. Thanks for this! Happy to merge this when the PR is updated and I'll get a new release spun out for this feature.

Apologies for taking a long time for getting this reviewed. I'm in the middle of wedding planning which leaves surprisingly little time for hacking on C# :)

[waf]

Are we able to use CultureInfo.GetCultureInfo(String) instead of looping through all the cultures?

If guess that if the user specifies some invalid culture, GetCultureInfo would throw -- I think it's fine to catch the exception and return some configuration error so the user knows their custom setting is not valid.

[waf]

I think this should be an error, rather than silently ignoring the user's configuration

[Keyros]

Just some minor feedback. Thanks for this! Happy to merge this when the PR is updated and I'll get a new release spun out for this feature.

Apologies for taking a long time for getting this reviewed. I'm in the middle of wedding planning which leaves surprisingly little time for hacking on C# :)

@waf Congratulations!!!

Сomments were resolved, now CultureNotFoundException is thrown

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (af2ac23) 0.0% compared to head (c4d7f14) 77.5%.
Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##           main    #296      +/-   ##
=======================================
+ Coverage   0.0%   77.5%   +77.5%     
=======================================
  Files        83      83              
  Lines      5573    5584      +11     
  Branches    733     736       +3     
=======================================
+ Hits          0    4328    +4328     
+ Misses     5573     988    -4585     
- Partials      0     268     +268     

Files	Coverage Δ
CSharpRepl.Services/Configuration.cs	81.8% <100.0%> (+81.8%)	⬆️
CSharpRepl/CommandLine.cs	94.6% <100.0%> (+94.6%)	⬆️
CSharpRepl/CSharpReplPromptCallbacks.cs	80.8% <50.0%> (+80.8%)	⬆️

... and 78 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.