Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update LibreSSL support #210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

semarie
Copy link

@semarie semarie commented Dec 31, 2022

build tested on OpenBSD 7.2-current (with LibreSSL 3.7.1)

one possible problem is SSL_client_version(). I used SSL_version() as alternative:

  • SSL struct is now opaque
  • SSL_client_version() is unavailable

but SSL_client_version() doesn't seems very useful, as according to the OpenSSL documentation, it is a partial result:

SSL_client_version() returns the numeric protocol version advertised by the client in the legacy_version field of the ClientHello when initiating the connection. Note that, for TLS, this value will never indicate a version greater than TLSv1.2 even if TLSv1.3 is subsequently negotiated.

It should fixe #209

build tested on OpenBSD 7.2-current (with LibreSSL 3.7.1)
Copy link
Collaborator

@daurnimator daurnimator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one possible problem is SSL_client_version(). I used SSL_version() as alternative

Instead of using SSL_version just throw an error that the client version is unavailable. getClientVersion exists to explicitly get the client version field, we already have :getVersion which uses SSL_version().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants