feat: use mesh peers instead of all peers for determining topic health #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (3)
|
|
Looks like a datarace has been detected, better to address it before merging. |
|
Hm, it seems that the way that go-libp2p-pubsub uses the
|
richard-ramos
force-pushed
the
topic-health
branch
2 times, most recently
from
63e2cf6
to
3fedd91
Compare
richard-ramos
force-pushed
the
topic-health
branch
from
3fedd91
to
5b3b9c7
Compare
|
I modified go-libp2p-pubsub to implement something similar to ListPeers. That solved the data race |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1131
I could not figure out the logic behind how
gs.meshis populated in go-lib2p2-pubsub, so in the meantime I disabled the test that check for connection changes