Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up db seeding file #197

Merged
merged 6 commits into from
Jul 2, 2024
Merged

clean up db seeding file #197

merged 6 commits into from
Jul 2, 2024

Conversation

vincanger
Copy link
Collaborator

@wasp-lang wasp-lang deleted a comment Jun 27, 2024
Copy link
Member

@Martinsos Martinsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort here, this will end up being very nice! Left some Clean Code (TM) comments!

template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
template/app/src/server/scripts/dbSeeds.ts Outdated Show resolved Hide resolved
Comment on lines +103 to +104
subscriptionStatus String? // 'active', 'canceled', 'past_due', 'deleted', null
subscriptionTier String? // 'hobby-tier', 'pro-tier', null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this on purpose or is this a leftover?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll leave it there until we get enums in v0.14

@vincanger vincanger merged commit 471217b into main Jul 2, 2024
1 check passed
@vincanger vincanger deleted the improve-seeding-file branch July 2, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants