Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guided-tour.md #204

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Update guided-tour.md #204

merged 2 commits into from
Jul 1, 2024

Conversation

fmaiabatista
Copy link
Contributor

Description

Describe your PR! If it fixes specific issue, mention it with "Fixes # (issue)".

Hey 馃憢

I'm going through the Guided Tour and I found that when I changed my app name, I also had to migrate the DB again, and my previous data was lost. I added this info to the warning box so other users are aware of the impact.

By the way, the Edit page button in the docs are pointing to the deployed-version branch, which I found to be outdated. I had to find the new path to the doc file in the main branch to propose the changes. See below:

image

Let me know if my understanding and proposed changes are accurate and feel free to merge the PR as is or further change the text!

Contributor Checklist

Make sure to do the following steps if they are applicable to your PR:

Hey 馃憢 

I'm going through the Guided Tour and I found that when I changed my app name, I also had to migrate the DB again, and my previous data was lost. I added this info to the warning box so other users are aware of the impact.
@Martinsos
Copy link
Member

Thanks for the insightful PR @fmaiabatista !

Based on your second suggestion (edit page), I creaetd this PR -> good catch!

As for the warning for app name change -> thanks, I modified it a bit but kept the intent / information. I will merge this now!

@Martinsos Martinsos merged commit e421e82 into wasp-lang:main Jul 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants