Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert Dependabot/npm and yarn/read pkg up 8.0.0 #107

Merged
merged 14 commits into from
Oct 21, 2021

Conversation

lprintf
Copy link
Contributor

@lprintf lprintf commented Sep 25, 2021

revert Dependabot/npm and yarn/read pkg up 8.0.0

@lprintf lprintf requested a review from huan September 25, 2021 12:39
@lprintf
Copy link
Contributor Author

lprintf commented Sep 25, 2021

#106

src/wechaty-manager.ts Outdated Show resolved Hide resolved
@huan
Copy link
Member

huan commented Oct 4, 2021

require will not work with ESM.

import a module first, then use it later.

See:

@lprintf
Copy link
Contributor Author

lprintf commented Oct 4, 2021

require will not work with ESM.

import a module first, then use it later.

See:

OK, I will try again. I use import before but reuse require for fix the check problem.

@lprintf
Copy link
Contributor Author

lprintf commented Oct 4, 2021

Now, It works well locally, but can't pass the check. It seem to be a problem about node smoke-testing.js of scripts/npm-pack-testing.sh.

@huan
Copy link
Member

huan commented Oct 4, 2021

Error: Cannot find module 'qrcode-terminal'

You need to install qrcode-terminal in scripts/npm-pack-testing.sh

Copy link
Member

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is why our CI is failing.

@huan huan merged commit 932e870 into main Oct 21, 2021
@huan huan deleted the dependabot/npm_and_yarn/read-pkg-up-8.0.0 branch October 21, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants