Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wolfBoot on Renesas RZN2L #411

Merged
merged 6 commits into from
Mar 2, 2024
Merged

Conversation

miyazakh
Copy link
Contributor

Initial Support wolfBoot on Renesas RZN2L

@dgarske
Copy link
Contributor

dgarske commented Feb 26, 2024

@danielinux and @dgarske will review this wolfBoot port. PR cap, no action needed.

IDE/Renesas/e2studio/RZN2L/Readme.md Outdated Show resolved Hide resolved
IDE/Renesas/e2studio/RZN2L/Readme.md Outdated Show resolved Hide resolved
IDE/Renesas/e2studio/RZN2L/Readme.md Show resolved Hide resolved
IDE/Renesas/e2studio/RZN2L/Readme.md Outdated Show resolved Hide resolved
IDE/Renesas/e2studio/RZN2L/Readme.md Outdated Show resolved Hide resolved
@@ -66,6 +66,10 @@ void do_boot(const uint32_t *app_offset)
*/
app_entry = (void(*)(void))(*VECTOR_Reset_Handler);
(*app_entry)();
#elif defined(_RENESAS_RZN_)
app_entry = (void(*))(0x10010000);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid hard coding. This should come from .config or a linker script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I use an address value of linker script.

hal/renesas-rz.c Show resolved Hide resolved
Copy link
Member

@danielinux danielinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Could you please add a short paragraph in docs/Targets.md, so it's consistent with the other Renesas ports, and the target is properly tracked in the docs?

[edit] ideally the section in Targets.md could also introduce the "verify/select candidate/load to ram" strategy required by the target, which is not obvious at first glance.

@dgarske dgarske assigned miyazakh and unassigned dgarske Feb 29, 2024
@miyazakh
Copy link
Contributor Author

Hi @danielinux
Thanks. I have added RZN2L into Targets.md and made some clean up.

@dgarske dgarske self-assigned this Feb 29, 2024
danielinux
danielinux previously approved these changes Mar 1, 2024
@danielinux
Copy link
Member

Looks good now, off to @dgarske for final comments & merge.

@danielinux danielinux removed their assignment Mar 1, 2024
dgarske
dgarske previously approved these changes Mar 1, 2024
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @miyazakh. Everything looks good. I will load this up in e2Studio as well and try to build them.

@dgarske dgarske dismissed stale reviews from danielinux and themself via 63da28c March 1, 2024 21:25
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference is full wolfBoot integration including startup code like I'm doing for PR #408, but I realize that is a lot more work. For now this is acceptable. Thank you

@dgarske dgarske merged commit e366924 into wolfSSL:master Mar 2, 2024
79 checks passed
@miyazakh miyazakh deleted the renesas_rz2 branch March 4, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants