library: Add search bar inside library view #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initial search bar (Code logic yet to be implemented)
WIP- Map stores demos and categories corresp to name Iterate through map and check if map entries contain user search term Similarly iterate through category map and disable categories with no corresp demo
sonnyp
requested changes
Jun 28, 2024
There was a problem hiding this comment.
Can you make sure to use snake_case instead of camelCase for variables
For example demo_name, categoryWidget, categoryName
Also - I found this bug; the illustration grows in size when there are no search results - it shouldn't happen.
Screencast.from.2024-06-28.13-48-56.mp4
Fix illustration growing in size when search results empty Remove unnecessary comments Less verbose code, optimize conditional statements
Adding the illustration inside a Screencast.from.2024-06-28.23-45-34.mp4 |
sonnyp
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial search bar widget (Code logic yet to be implemented)
Let me know if there are any improvements!
Screengrab of the change:
2024-06-26.21-39-04.mp4