Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix task2 for windows cmd #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

thyecust
Copy link

This is concerned with #99.

My modification

  1. add path.join, otherwise copy function can not properly copy the cc file to the temporary folder
  2. replace the single quotation marks with the double quotation marks, otherwise will get The filename, directory name, or volume label syntax is incorrect. on windows cmd.

Copy link
Member

@kid-icarus kid-icarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thyecust
Copy link
Author

Only those with write access to this repository can merge pull requests. @kid-icarus could you help to merge this? Thanks.

@kid-icarus
Copy link
Member

@thyecust any way you can test this in a unix environment? we don't currently have automation set up

@pqnet
Copy link

pqnet commented Dec 14, 2023

The same issue is present on other exercises as well, such as part 3. The root cause is that the copy function doesn't work when "to" is a directory in Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants