Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotes adventure: add testcase that checks symbols(+ * =) within the … #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Quotes adventure: add testcase that checks symbols(+ * =) within the … #14

wants to merge 1 commit into from

Conversation

ktopolski
Copy link

…quotation marks.

@ktopolski
Copy link
Author

Hey there,

I was doing the "Quotes" step and I found out that my regex, /("(\w|\s)*")/g, which does not check symbols within the quotation marks, is passing all the tests. After seeing proposed solution(/"[^"]*"/g) I figured out that it's better because it checks for symbols too. To aware other people taking this adventure I added test case to check for symbols in "Quotes" step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ktopolski