Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong taxonomy label case in product attributes #869

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

creative-andrew
Copy link
Contributor

What does this implement/fix? Explain your changes.

Product attribute taxonomy labels are returned with all words in uppercase.
There is no need to call ucwords as the label is correctly saved on the database taxonomy object.

/var/www/html $ wp taxonomy get pa_schirmgroesse
Field         | Value                                                                                                                                                   
name          | pa_schirmgroesse                                                                                                                                        
label         | Produkt Schirmgröße in cm                                                                                                                              

Data returned by wp-graphql-woocommerce

image

with the fix applied:

image

Where has this been tested?

  • **WooGraphQL Version: 0.19.0
  • **WPGraphQL Version: 1.25.0
  • **WordPress Version: 6.5.3
  • **WooCommerce Version: 8.8.3

@creative-andrew creative-andrew changed the title fix: wrong taxonomy label in product attributes fix: wrong taxonomy label case in product attributes Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant