feat: add Spanish translations #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
top90-frontend
|
||||||||||||||||||||||||||||||||||
| Project |
top90-frontend
|
| Branch Review |
spanish-translations
|
| Run status |
|
| Run duration | 00m 31s |
| Commit |
|
| Committer | astone123 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
10
|
| View all changes introduced in this branch ↗︎ | |
Accessibility
80.68%
|
|
|---|---|
|
Failed rules
|
4 critical
1 serious
3 moderate
1 minor
|
|
Failed elements
|
650
|
wweitzel
reviewed
Jan 2, 2024
| <div>{date.toDateString()}</div> | ||
| <div>{formattedTime(date)}</div> | ||
| {/* Sat Dec 23 2023 */} | ||
| <div>{format(date, 'EEE MMM d yyyy', {locale: localesMap[navigator.language]})}</div> |
There was a problem hiding this comment.
@astone123 Can we encapsulate this logic to "get the user's current locale.Locale" somewhere so that we don't have to define localsMap and do localesMap[navigator.language]} every time we want it?
wweitzel
reviewed
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Spanish translations with
react-i18next. It also adds a Prettier extension for sorting keys in JSON files to keep our translation files organized.You can test this by changing the language in your browser to Spanish