Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Vite #39

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Switch to Vite #39

merged 3 commits into from
Aug 31, 2023

Conversation

GIT-Gizmo
Copy link
Contributor

I have successfully migrated CRA to Vite. You can merge and check it out

@wweitzel
Copy link
Owner

Hey! Thanks, npm run build is not working on this PR. In tsconfig.json we need to set "module": "ESNext" and we also need to add "moduleResolution": "node". Then it should work.

wweitzel
wweitzel reviewed Aug 31, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@wweitzel
Copy link
Owner

Two more things:

  1. You will need to run npm run format and commit the changes to get this to pass CI
  2. I'm not entirely sure what the new vite-env.d.ts file is for. But everything still seems to work if I remove it. Can you remove that file and commit the change? I'd prefer not to have it if we don't need it.

@GIT-Gizmo
Copy link
Contributor Author

Sure, I'll do that 👍

@GIT-Gizmo
Copy link
Contributor Author

Done

@wweitzel
Copy link
Owner

wweitzel commented Aug 31, 2023 •
edited
Loading

Thanks! I made some other comments for changes that need to be made for this to work. After you address those, we should be good to go. Let me know if you have any questions. The comments are these

@GIT-Gizmo
Copy link
Contributor Author

Oh ok, I've done that. I believe it should be good now👍

@wweitzel
Copy link
Owner

Thanks! There is a small issue with the tests but I can fix that later. Im merging this now. Closes #28

wweitzel
wweitzel approved these changes Aug 31, 2023
View reviewed changes
Copy link
Owner

@wweitzel wweitzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wweitzel wweitzel changed the title Successfully migrated from CRA(create-react-app) to Vite Switch to Vite Aug 31, 2023
@wweitzel wweitzel merged commit a248b10 into wweitzel:master Aug 31, 2023
1 check failed
@GIT-Gizmo
Copy link
Contributor Author

Awesome, glad I could help in my own little way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wweitzel wweitzel wweitzel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GIT-Gizmo @wweitzel