Frontend cleanup #78
Merged
Frontend cleanup #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
david-c-smith
commented
Nov 30, 2023
•
david-c-smith
commented
- improved accessibility score by 6
- reorganized some components
- added logic for displaying "just now", "minutes ago", "hours ago"
- extracted some urls into separate variables
- other small improvements
wweitzel
reviewed
Nov 30, 2023
| @@ -26,17 +26,19 @@ function Select({ | |||
| const currentOption = options?.find((option) => option.value == value); | |||
| const [searchText, setSearchText] = useState(''); | |||
|
|
|||
| const dropdownId = `dropdown-${Math.random().toString(36).substring(7)}`; | |||
There was a problem hiding this comment.
accessibility portion of lighthouse wanted a unique id per label so i just did random gen
wweitzel
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.