chore: use date-fns formatting function for timestamps #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wweitzel
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
nice. would be good to use date-fns for this as well https://github.com/wweitzel/top90-frontend/blob/master/src/components/FixtureRow.tsx#L15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our current relative timestamp logic with
date-fns. This increases the bundle size by about 11kb (4kb gzipped), and adds less than half a second onto production build time.It also makes the code more readable and will help us with internationalization in the future
Before
After