Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to create usergroup based policy rules #6398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samveen
Copy link
Member

@samveen samveen commented Aug 7, 2019

The PR is to implement feature #1848

##Feature description##
In the case of lots of users (or user churn) of a cluster, it is easier to add a group based policy instead of creating individual policies for users.

Code logic:

  • Given the request's peername, get the groups for the user.
  • If the group list contains the rule name, it's a match, so carry forward as previously, or check for username and carry forward as previously.

The UT result

As I no longer have access to an xCAT environment, I am unable to unit-test this.

@samveen
Copy link
Member Author

samveen commented Aug 7, 2019

@gurevichmark @whowutwut would you please review this?

@besawn besawn self-assigned this Aug 29, 2019
@samveen samveen changed the title [WIP] Add ability to create usergroup based policy rules Add ability to create usergroup based policy rules Jan 14, 2020
This implements feature request xcat2#1848

Signed-off-by: Samveen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants