Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various GitHub Action xcat_test fixes #7421

Merged
merged 4 commits into from
Feb 12, 2024

Conversation

Obihoernchen
Copy link
Member

@Obihoernchen Obihoernchen commented Feb 10, 2024

  • Upgrade to actions/checkout@v4 to fix the following GitHub warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

  • Add a 60 minute timeout. Let's not waste resources if our CI job has issues
  • Remove duplicate makedhcp_n_linux test case
  • Add step names

@Obihoernchen Obihoernchen added this to the 2.17 milestone Feb 10, 2024
@Obihoernchen Obihoernchen self-assigned this Feb 10, 2024
Looks like this actions hangs from time to time. Let's use a reasonable default to get faster failing messages.
makedhcp_n_linux is the same as makedhcp_n. It doesn't make sense to run
both test cases.
@Obihoernchen Obihoernchen changed the title Fix node16 deprecation warning Various GitHub Action xcat_test fixes Feb 11, 2024
@Obihoernchen Obihoernchen merged commit 65b5c72 into xcat2:master Feb 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants