-
-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache path vs Local path #602
base: main
Are you sure you want to change the base?
Conversation
1 similar comment
Xenova is currently overwhelmed with the release of v3, but will for sure review your PR as soon as possible. |
Thank you! Happy to help however I can (PR's / Issues / etc), please let me know how to contribute best 😃 |
Hi! This has been open for a bit... its a small change I promise :) Fixes issues in this issue (multiple people are experiencing): #520 |
Following up on this! Please let me know how to move forward with your merging process? |
Sorry it hasn't been merged yet, @axrati. But only Xenova can make it. |
@xenova following up on this! |
This aims to fix an issue where providing a directory for a model in a different parent directory/tree results in an error.
There is a split handling between cache path and local path - mostly because I wasn't sure behind all use case implementations (browser vs local vs X). This solutions solves providing file paths such as
../../your_model_dir
as theenv.localModelPath
variable.