Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix destroy callback never to be called #542

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix destroy callback never to be called #542

merged 1 commit into from
Jan 17, 2024

Conversation

narttmk
Copy link
Contributor

@narttmk narttmk commented Jan 17, 2024

No description provided.

@narttmk narttmk mentioned this pull request Jan 17, 2024
Closed
@yaacov yaacov added the bug label Jan 17, 2024
@yaacov yaacov merged commit b49090b into yaacov:master Jan 17, 2024
3 checks passed
@yaacov
Copy link
Owner

yaacov commented Jan 17, 2024

thanks 💚

@AndreMaz
Copy link
Contributor

@yaacov was this released? If the answer is no, can you please do it?

@yaacov
Copy link
Owner

yaacov commented May 28, 2024

https://www.npmjs.com/package/modbus-serial/v/8.0.17 - 🎉 🍰

@AndreMaz
Copy link
Contributor

Super! Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@narttmk @yaacov @AndreMaz