Add PV patch verb to support external-provisioner v5 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to support external-provisioner-runner with version >= v5.0.0.
When using external-provisioner-runner of version >= v5.0.0, it requires patch permission for PersistentVolumes to work.
https://github.com/kubernetes-csi/external-provisioner/blob/v5.0.0/CHANGELOG/CHANGELOG-5.0.md
The default provisioner versions specified in deploy folder are both v2.1.0 (which is quite old btw).
Although this is not strictly required for provisioner with version < v5, since the image and version of the provisioner is configurable via
values.yaml, I think it is a good idea to support newer versions as well.